test: remove max-doc-length from tox.ini file due to community recommendation #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [pycodestyle] | ||
| exclude = .git,.tox | ||
| max-line-length = 120 | ||
| max-doc-length = 79 |
There was a problem hiding this comment.
Do you want to remove the check altogether and not go for max-doc-length = 120?
Member
Author
There was a problem hiding this comment.
You're right. I was following edx-django-utils configuration. But then I found this: https://edx.readthedocs.io/projects/edx-developer-guide/en/latest/style_guides/python-guidelines.html#syntax-and-organization
Please use 79 chars as a limit for docstring lines though, so that the text remains readable.
I think I'm gonna close this issue. Thanks for the review though!
mariajgrimaldi
force-pushed
the
MJG/remove_doc_max_line
branch
from
8183e79 to
4dcee66
Compare
MoisesGSalas
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for 120 max doc lines. Suggestion taken from: https://github.com/eduNEXT/openedx-events/pull/18#discussion_r675183610