-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add Medatada as data attribute #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f48ffd3 to
78caadf
Compare
7f468a2 to
5a3e3df
Compare
78caadf to
fcf3c27
Compare
5a3e3df to
10d858c
Compare
fcf3c27 to
7d3ece2
Compare
10d858c to
d3ae682
Compare
7d3ece2 to
973eb05
Compare
d3ae682 to
861c1c5
Compare
de63450 to
ab0023b
Compare
- Add signal class used to create events - Add metadata generator to class - Add argument validator to class - Override signal methods to recommend using the custom send_event
…Attr to be less specific
ca605d7 to
d3dcca8
Compare
ab0023b to
6b78646
Compare
5a9cf69 to
871f98c
Compare
871f98c to
8707785
Compare
Member
|
This PR was only a POC right? Once the EventsMetadata attr class was added to #7, this is no longer needed. Can we close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR modifies the metadata object sent when triggering an Open edX event.
JIRA: Link to JIRA ticket
Dependencies:
This PR depends on #8
Merge deadline: List merge deadline (if any)
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: