Skip to content

Conversation

@mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Jul 19, 2021

Description:

This PR modifies the metadata object sent when triggering an Open edX event.

JIRA: Link to JIRA ticket

Dependencies:
This PR depends on #8

Merge deadline: List merge deadline (if any)

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Install openedx-events using the current branch
  2. Go to Django shell:
>>> from openedx_events.tooling import OpenEdxPublicSignal
>>> public_signal = OpenEdxPublicSignal(event_type="org.openedx.learning.session.login.completed.v1", data={'user': None})
>>> public_signal.generate_signal_metadata()
{'id': UUID('b6af26cc-ee39-11eb-8988-0242ac19000b'), 'event_type': 'org.openedx.learning.session.login.completed.v1', 'minorversion': 0, 'time': datetime.datetime(2021, 7, 26, 17, 48, 41, 41263), 'source': 'openedx/lms/web', 'sourcehost': 'lms.devstack.edx', 'sourcelib': (0, 1, 3)}

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns:

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/tooling_metadata_attr branch from f48ffd3 to 78caadf Compare July 19, 2021 19:24
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/tooling_metadata_attr branch from 78caadf to fcf3c27 Compare July 19, 2021 22:50
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/tooling_metadata_attr branch from fcf3c27 to 7d3ece2 Compare July 19, 2021 22:57
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/tooling_metadata_attr branch from 7d3ece2 to 973eb05 Compare July 20, 2021 12:06
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/tooling_metadata_attr branch 5 times, most recently from de63450 to ab0023b Compare July 22, 2021 17:10
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review July 26, 2021 16:31
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/tooling_metadata_attr branch from ab0023b to 6b78646 Compare July 27, 2021 13:46
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/event_data branch 2 times, most recently from 5a9cf69 to 871f98c Compare July 27, 2021 16:25
@felipemontoya
Copy link
Member

This PR was only a POC right? Once the EventsMetadata attr class was added to #7, this is no longer needed. Can we close it?

@mariajgrimaldi mariajgrimaldi deleted the MJG/tooling_metadata_attr branch July 28, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants