fix: Remove libraries v2 check from enforcer.#294
Merged
mariajgrimaldi merged 1 commit intoMay 21, 2026
Conversation
dianakhuang
force-pushed
the
diana/enforcer-import
branch
3 times, most recently
from
9d42122 to
f6a45f0
Compare
This was originally added as a performance improvement when libraries v2 was disabled, but it causes downstream errors when libraries v2 data exists even if libraries v2 is disabled. The behavior would default to true in almost every case anyway due to a circular import in the toggles check on openedx-platform.
dianakhuang
force-pushed
the
diana/enforcer-import
branch
from
f6a45f0 to
3fae13a
Compare
mariajgrimaldi
approved these changes
May 21, 2026
Member
mariajgrimaldi
left a comment
mariajgrimaldi
left a comment
There was a problem hiding this comment.
LGTM! Thanks so much for all the hard work on this. Appreciate it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally added as a performance improvement when libraries v2 was disabled, but it causes downstream errors when libraries v2 data exists even if libraries v2 is disabled.
The behavior would default to true in almost every case anyway due to a circular import in the toggles check on openedx-platform.
Merge checklist:
Check off if complete or not applicable: