-
Notifications
You must be signed in to change notification settings - Fork 6
Open Responses Summary #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 0.00% 70.00% +70.00%
==========================================
Files 5 37 +32
Lines 7 320 +313
Branches 0 80 +80
==========================================
+ Hits 0 224 +224
- Misses 7 96 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f50b7aa to
89814f6
Compare
ffb329f to
24d82ff
Compare
24d82ff to
aa8ea43
Compare
2a44187 to
0ef54e0
Compare
jesusbalderramawgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good!
| <div className="col-sm-2 col-lg-1"> | ||
| <p className="mb-2">{intl.formatMessage(messages.totalResponses)}</p> | ||
| </div> | ||
| <div className="col-sm-2 col-lg-1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to use col-sm-2 in some metric divs and col-sm-1 in some others? It makes the saparation of each metric different and looks a bit weird. I mean, in example the horizontal separation between trainning and peer is not the same as the one between peer and self.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm yeah it looks weird too. What if you try a different approach like using flex or the Stack component from paragon instead if row and col?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import { getOpenResponsesData } from './api'; | ||
| import { openResponsesQueryKeys } from './queryKeys'; | ||
|
|
||
| export const useOpenResponsesData = (courseId: string) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add unit tests to cover this file.
a10cd93 to
b35a5b5
Compare
b35a5b5 to
37f869c
Compare
37f869c to
643a512
Compare


Description
Created Open Responses summary component
Screenshot
Small Screen / Mobile

Supporting information
Closes #59
Testing instructions
Please provide detailed step-by-step instructions for manually testing this change.
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'