Skip to content

Conversation

@diana-villalvazo-wgu
Copy link
Contributor

@diana-villalvazo-wgu diana-villalvazo-wgu commented Nov 29, 2025

Description

Created Open Responses summary component

Screenshot

Screenshot 2026-01-21 at 1 09 39 p m

Small Screen / Mobile
Screenshot 2026-01-21 at 1 10 33 p m

Supporting information

Closes #59

Testing instructions

Please provide detailed step-by-step instructions for manually testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 29, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 29, 2025

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instruct.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 29, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Nov 29, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Waiting on Author in Contributions Nov 29, 2025
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.00%. Comparing base (5b0d465) to head (643a512).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/openResponses/data/api.ts 0.00% 4 Missing ⚠️
src/openResponses/data/apiHook.ts 0.00% 3 Missing ⚠️
src/openResponses/data/queryKeys.ts 0.00% 3 Missing ⚠️
src/openResponses/OpenResponsesPage.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #72       +/-   ##
==========================================
+ Coverage   0.00%   70.00%   +70.00%     
==========================================
  Files          5       37       +32     
  Lines          7      320      +313     
  Branches       0       80       +80     
==========================================
+ Hits           0      224      +224     
- Misses         7       96       +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 59/ORA-summary branch 3 times, most recently from ffb329f to 24d82ff Compare December 10, 2025 18:38
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 59/ORA-summary branch 2 times, most recently from 2a44187 to 0ef54e0 Compare January 20, 2026 21:41
@diana-villalvazo-wgu diana-villalvazo-wgu marked this pull request as ready for review January 20, 2026 22:47
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Waiting on Author to Ready for Review in Contributions Jan 20, 2026
Copy link

@jesusbalderramawgu jesusbalderramawgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good!

<div className="col-sm-2 col-lg-1">
<p className="mb-2">{intl.formatMessage(messages.totalResponses)}</p>
</div>
<div className="col-sm-2 col-lg-1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use col-sm-2 in some metric divs and col-sm-1 in some others? It makes the saparation of each metric different and looks a bit weird. I mean, in example the horizontal separation between trainning and peer is not the same as the one between peer and self.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in small screens because if we put 1 col for every one it looks weird , some texts are too close in some cases overlaps so i preferred to add some extra spacing for columns with long texts, and since they are 7 columns i can't give 2 col each

Screenshot 2026-01-21 at 1 13 30 p m

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm yeah it looks weird too. What if you try a different approach like using flex or the Stack component from paragon instead if row and col?

Copy link
Contributor Author

@diana-villalvazo-wgu diana-villalvazo-wgu Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2026-01-22 at 4 49 32 p m

With Flex and Stack is hard to align the metrics with the labels 😞 thats why grid/cols was my first choice

import { getOpenResponsesData } from './api';
import { openResponsesQueryKeys } from './queryKeys';

export const useOpenResponsesData = (courseId: string) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add unit tests to cover this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

Ticket – View Summary of Open Responses

5 participants