Skip to content

[WIP] refactor: remove useNewCourseOutlinePage flag from textbooks breadcrumb#3067

Open
farhan wants to merge 4 commits into
openedx:masterfrom
farhan:farhan/remove-legacy-waffle-flags-phase-1a
Open

[WIP] refactor: remove useNewCourseOutlinePage flag from textbooks breadcrumb#3067
farhan wants to merge 4 commits into
openedx:masterfrom
farhan:farhan/remove-legacy-waffle-flags-phase-1a

Conversation

@farhan
Copy link
Copy Markdown

@farhan farhan commented May 21, 2026

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be linked here.

Useful information to include:

  • Which user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).

Supporting information

Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for manually testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

The flag always resolves to the MFE route; hardcode to /course/${courseId}
and drop waffleFlags from the useTextbooks signature and its caller.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.55%. Comparing base (36d42b0) to head (4a061ec).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3067   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files        1393     1393           
  Lines       32992    32979   -13     
  Branches     7644     7654   +10     
=======================================
- Hits        31524    31514   -10     
+ Misses       1413     1399   -14     
- Partials       55       66   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

farhan and others added 3 commits May 21, 2026 19:48
…crumb

Hardcode breadcrumb to /course/${courseId} and drop the useWaffleFlags
call and import, as the flag is no longer needed in this component.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Courses always use the MFE destination URL now; drop the waffle flag
guard and its call/import from the card-item component.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Hardcode outline link to MFE path and drop the waffle flag guard,
useWaffleFlags call, and getConfig import from ChecklistItemComment.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bradenmacdonald
Copy link
Copy Markdown
Contributor

Let me know when you'd like me to review this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants