fix: make sidebar sticky, fix styles, responsiveness, scroll and remove padding#3057
fix: make sidebar sticky, fix styles, responsiveness, scroll and remove padding#3057rpenido wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3057 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 1393 1393
Lines 32969 32971 +2
Branches 7592 7600 +8
=======================================
+ Hits 31493 31495 +2
Misses 1408 1408
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a95cc72 to
505cd04
Compare
47a2e51 to
d506490
Compare
d506490 to
e7b8ce6
Compare
Description
This PR fixes an issue introduced by #3056 and #3055, in which the sidebar lost its sticky style after adding a div to wrap it, alongside some styles, responsiveness, and scroll.
It also removes the padding added by #3055, which causes misalignment with the main content on the left.
Supporting information
Testing instructions
npm run buildenv.config.jsxto see the behaviour with insert/wrapping components:Note: The flex classes in the wrapping divs are necessary so the content adapts to the remaining space correctly.
100vhand occupies the whole left while scrolling.Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'