-
Notifications
You must be signed in to change notification settings - Fork 179
fix: clean up invalid breadcrumb usages #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: clean up invalid breadcrumb usages #2811
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8fc7201 to
b25ed91
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2811 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 1267 1267
Lines 29292 29292
Branches 6692 6692
=======================================
Hits 27850 27850
Misses 1372 1372
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bradenmacdonald The code looks good! But, in my instance, the change is noticeable:
|
|
@bradenmacdonald Yes, it looks a bit weird. The unicode arrow looks small. |
|
@ChrisChV @navinkarkera Weird, I wonder why it's so different for you guys. I thought with web fonts these days, things would be more consistent than that. How about I just change it to not use |
|
@bradenmacdonald That should work. |
b25ed91 to
3d1c089
Compare
3d1c089 to
40bedd1
Compare
|
@ChrisChV @navinkarkera I've updated this PR. Can you please take another look? |
navinkarkera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradenmacdonald Looks good.
| linkAs={Button} | ||
| /> | ||
| <Stack direction="horizontal" gap={1}> | ||
| <Button variant="link" className="px-0" onClick={onBackBtnClick}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <Button variant="link" className="px-0" onClick={onBackBtnClick}> | |
| <Button variant="link" className="px-0 text-gray-900" onClick={onBackBtnClick}> |

Description
When trying to pull in the newest version of Paragon, some type errors were showing up. I'm fixing some of them in openedx/paragon#4077 but others should be fixed in this repo.
The Paragon Breadcrumb
labelis used as akeyin various places and so should be a string. It also needs to be unique, which seems bad but that's how it's implemented. So I've changed the container changes preview "Back" breadcrumb to a horizontal stack with a button and a title:I also fixed some missing i18n for the word "Back", and changed a user-visible message to not include the term "Breadcrumb" which is a technical term that users may not know.
I also changed
targettocurrentTargetin an event handler. For an element with no children, these will always be the same, but with the changes in openedx/paragon#4077 , onlycurrentTargetwill have the correctHTMLElementtyping required to accessdata-attributes, because in theory thetargetvalue could be a totally different child element.Supporting information
Together with openedx/paragon#4077 , this will unblock #2765 .
Testing instructions
Check that the "Library Updates" page is working as normal.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'Private ref: MNG-4846