Skip to content

fix: prefetch video_image when getting a video #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viadanna wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Open

fix: prefetch video_image when getting a video #596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af5ddba
fix: prefetch video_image when getting a video
viadanna Feb 19, 2026
0940e7a
fix: prefetch encoded_videos when getting a video
viadanna May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions edxval/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,9 +540,10 @@ def _get_video(edx_video_id):
"""
try:
encoded_videos = EncodedVideo.objects.select_related("profile")
course_videos = CourseVideo.objects.select_related("video_image")
return Video.objects \
.prefetch_related(Prefetch("encoded_videos", queryset=encoded_videos)) \
.prefetch_related("courses") \
.prefetch_related(Prefetch("courses", queryset=course_videos)) \
.get(edx_video_id=edx_video_id)
Comment on lines 542 to 547
except Video.DoesNotExist as no_video_error:
error_message = f"Video not found for edx_video_id: {edx_video_id}"
Expand Down Expand Up @@ -649,7 +650,12 @@ def _get_videos_for_filter(video_filter, sort_field=None, sort_dir=SortDirection
the given field and direction, with ties broken by edx_video_id to ensure a
total order.
"""
videos = Video.objects.filter(**video_filter)
video_image = CourseVideo.objects.select_related("video_image")
encoded_videos = EncodedVideo.objects.select_related("profile")
videos = Video.objects \
.prefetch_related(Prefetch("courses", queryset=video_image)) \
Comment on lines +653 to +656
.prefetch_related(Prefetch("encoded_videos", queryset=encoded_videos)) \
.filter(**video_filter)
Comment on lines +655 to +658
paginator_context = {}

if sort_field:
Expand Down
Loading