Skip to content

docs(sharing): badges and verifiable credentials documentation rework#2968

Open
GlugovGrGlib wants to merge 5 commits intoopenedx:masterfrom
GlugovGrGlib:g-glugovskiy/badges-documentation-corrections
Open

docs(sharing): badges and verifiable credentials documentation rework#2968
GlugovGrGlib wants to merge 5 commits intoopenedx:masterfrom
GlugovGrGlib:g-glugovskiy/badges-documentation-corrections

Conversation

@GlugovGrGlib
Copy link
Copy Markdown
Member

@GlugovGrGlib GlugovGrGlib commented Mar 11, 2026

Description

A major revamp of developer's and operator's documentation related to credentials sharing and implementations of the badging and verifiable credentials.

Some notable changes include:

  • Reorganize the badges and verifiable credentials docs under a new docs/sharing/ parent directory.
  • Move infrastructure topics below user-facing features for better discoverability in docs/index.rst toctree.
  • Expand badges and verifiable credentials documentation with new pages for configuration and technical references.
  • Add C4 architecture diagrams and VC lifecycle diagram.
  • Update README with improved project description.

Testing instructions

See the latest docs build at https://docsopenedxorg--2968.org.readthedocs.build/projects/edx-credentials/en/2968/

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 11, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Mar 11, 2026

Thanks for the pull request, @GlugovGrGlib!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 11, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 11, 2026
@GlugovGrGlib GlugovGrGlib changed the title docs(sharing): badges and verifiable credentials documentation update docs(sharing): badges and verifiable credentials documentation rework Mar 25, 2026
@GlugovGrGlib GlugovGrGlib requested a review from sarina March 25, 2026 13:54
@GlugovGrGlib GlugovGrGlib marked this pull request as ready for review March 25, 2026 14:00
@sarina
Copy link
Copy Markdown
Contributor

sarina commented Mar 31, 2026

I think the PR description might be incorrect - for docs PRs, it's often nice to link to all the changed pages within the build. But no need to do that I'm already trying to find them.

Copy link
Copy Markdown
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really huge PR. I spent over an hour with it and only got halfway through. I will try to find more time soon to finish.

openedX = softwareSystem "Open edX" {
edxPlatform = container "openedx-platform" "LMS and course management" "Python/Django"
eventBus = container "Event Bus" "Redis Streams or Kafka" "" "Queue"
credentialsService = container "edX Credentials" "Stores learner achievements, issues credentials" "Python/Django" {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call the service "Open edX Credentials", or is there a reason it needs to be "edX Credentials"?

}
element "Software System" {
background "#1168bd"
color "#ffffff"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] these diagrams rely heavily on shades of blue, which may not be very accessible. Further, black on light blue probably doesn't pass accessible contrast ratios.

-----------------------------

Multiple Accredible API Configurations can be configured.
All communication between Open edX Credentials and Accredible happens on behalf of an Accredible API config.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All communication between Open edX Credentials and Accredible happens on behalf of an Accredible API config.
All communication between Open edX Credentials and Accredible happens on behalf of an Accredible API configuration within the Open edX platform.

Multiple Accredible API Configurations can be configured.
All communication between Open edX Credentials and Accredible happens on behalf of an Accredible API config.

Go to the Accredible API Configs section in the admin panel and create a new item:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Go to the Accredible API Configs section in the admin panel and create a new item:
Go to the Accredible API Configs section in your instance's admin panel and create a new item:

Synchronization
~~~~~~~~~~~~~~~

To synchronize Accredible groups for an API Configuration:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do I need to do this? When do I need to do this?


**Data rule**
A filter on a requirement's event payload
(e.g. ``course.course_key equals course-v1:edX+DemoX``).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we're giving an example of a course key can we use course-v1:OpenedX+DemoX+Demo_Course since that's the way the course key is expressed in https://github.com/openedx/openedx-demo-course/blob/master/demo-course/course/course.xml (which is the demo course you can load into your Open edX instance)


For **Credly**:

#. Select one or more organizations on the "Credly Organizations" list page.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there Credly docs we can point to here?


For **Accredible**:

#. Select one or more configurations on the "Accredible API Configs" list
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there Accredible docs we can point to here?


.. note::

Each badge is an extended version of a user credential record.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this means or why it needs to be in a callout box

-------------------------

Deactivate a badge template by unchecking the ``is active`` checkbox
on its edit page. See :ref:`badges-configuration` for activation details.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a reflink to the actual "Activation" section on this page?

Also probably worth noting (a) that you need to also Save the configuration when unchecking the is_active checkbox, and (b) what the consequences of doing this are (eg, are badges revoked or retained? Are there any side effects?)

Also why doesn't the https://docsopenedxorg--2968.org.readthedocs.build/projects/edx-credentials/en/2968/sharing/badges/configuration/index.html#activation section also describe disabling it? Seems weird that the Activation instructions aren't coupled with Deactivation instructions.

@GlugovGrGlib
Copy link
Copy Markdown
Member Author

GlugovGrGlib commented Mar 31, 2026

@sarina You're right about the description, this comes from the default PR template. I'll update it shortly.
Thanks for the review and suggestions. Please, take your time to finish it. I'll start working on fixes meanwhile for what has already been mentioned, but I won't push updates until you finish this pass to not disrupt you.

@GlugovGrGlib GlugovGrGlib self-assigned this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: No status
Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

4 participants