docs(sharing): badges and verifiable credentials documentation rework#2968
docs(sharing): badges and verifiable credentials documentation rework#2968GlugovGrGlib wants to merge 5 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @GlugovGrGlib! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
I think the PR description might be incorrect - for docs PRs, it's often nice to link to all the changed pages within the build. But no need to do that I'm already trying to find them. |
sarina
left a comment
There was a problem hiding this comment.
This is a really huge PR. I spent over an hour with it and only got halfway through. I will try to find more time soon to finish.
| openedX = softwareSystem "Open edX" { | ||
| edxPlatform = container "openedx-platform" "LMS and course management" "Python/Django" | ||
| eventBus = container "Event Bus" "Redis Streams or Kafka" "" "Queue" | ||
| credentialsService = container "edX Credentials" "Stores learner achievements, issues credentials" "Python/Django" { |
There was a problem hiding this comment.
Can we call the service "Open edX Credentials", or is there a reason it needs to be "edX Credentials"?
| } | ||
| element "Software System" { | ||
| background "#1168bd" | ||
| color "#ffffff" |
There was a problem hiding this comment.
[suggestion] these diagrams rely heavily on shades of blue, which may not be very accessible. Further, black on light blue probably doesn't pass accessible contrast ratios.
| ----------------------------- | ||
|
|
||
| Multiple Accredible API Configurations can be configured. | ||
| All communication between Open edX Credentials and Accredible happens on behalf of an Accredible API config. |
There was a problem hiding this comment.
| All communication between Open edX Credentials and Accredible happens on behalf of an Accredible API config. | |
| All communication between Open edX Credentials and Accredible happens on behalf of an Accredible API configuration within the Open edX platform. |
| Multiple Accredible API Configurations can be configured. | ||
| All communication between Open edX Credentials and Accredible happens on behalf of an Accredible API config. | ||
|
|
||
| Go to the Accredible API Configs section in the admin panel and create a new item: |
There was a problem hiding this comment.
| Go to the Accredible API Configs section in the admin panel and create a new item: | |
| Go to the Accredible API Configs section in your instance's admin panel and create a new item: |
| Synchronization | ||
| ~~~~~~~~~~~~~~~ | ||
|
|
||
| To synchronize Accredible groups for an API Configuration: |
There was a problem hiding this comment.
Why do I need to do this? When do I need to do this?
|
|
||
| **Data rule** | ||
| A filter on a requirement's event payload | ||
| (e.g. ``course.course_key equals course-v1:edX+DemoX``). |
There was a problem hiding this comment.
When we're giving an example of a course key can we use course-v1:OpenedX+DemoX+Demo_Course since that's the way the course key is expressed in https://github.com/openedx/openedx-demo-course/blob/master/demo-course/course/course.xml (which is the demo course you can load into your Open edX instance)
|
|
||
| For **Credly**: | ||
|
|
||
| #. Select one or more organizations on the "Credly Organizations" list page. |
There was a problem hiding this comment.
Is there Credly docs we can point to here?
|
|
||
| For **Accredible**: | ||
|
|
||
| #. Select one or more configurations on the "Accredible API Configs" list |
There was a problem hiding this comment.
Is there Accredible docs we can point to here?
|
|
||
| .. note:: | ||
|
|
||
| Each badge is an extended version of a user credential record. |
There was a problem hiding this comment.
I don't understand what this means or why it needs to be in a callout box
| ------------------------- | ||
|
|
||
| Deactivate a badge template by unchecking the ``is active`` checkbox | ||
| on its edit page. See :ref:`badges-configuration` for activation details. |
There was a problem hiding this comment.
Could you provide a reflink to the actual "Activation" section on this page?
Also probably worth noting (a) that you need to also Save the configuration when unchecking the is_active checkbox, and (b) what the consequences of doing this are (eg, are badges revoked or retained? Are there any side effects?)
Also why doesn't the https://docsopenedxorg--2968.org.readthedocs.build/projects/edx-credentials/en/2968/sharing/badges/configuration/index.html#activation section also describe disabling it? Seems weird that the Activation instructions aren't coupled with Deactivation instructions.
|
@sarina You're right about the description, this comes from the default PR template. I'll update it shortly. |
Description
A major revamp of developer's and operator's documentation related to
credentials sharingand implementations of thebadgingandverifiable credentials.Some notable changes include:
docs/sharing/parent directory.docs/index.rsttoctree.READMEwith improved project description.Testing instructions
See the latest docs build at https://docsopenedxorg--2968.org.readthedocs.build/projects/edx-credentials/en/2968/