feat: allowing the passing of a logging formatter #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow the configuration of logging to pass a custom format string for the logs * adding type hints and a more complete docstring to the modified method FIXES: APER-3805
* adding some tests for the log formatter * Making it we can modify config values via yaml (ie. without passing a python function) FIXES: APER-3805
jsnwesson
reviewed
Nov 26, 2024
jsnwesson
approved these changes
Nov 26, 2024
Member
jsnwesson
left a comment
jsnwesson
left a comment
There was a problem hiding this comment.
Approved, other than that one bit about the documentation syntax
the style guide calls for this exception to pep 257. Co-authored-by: Jason Wesson <jsnwesson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: APER-3805