Open
Conversation
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
angelmp01
reviewed
Mar 26, 2026
| this.componentId = componentId; | ||
| } | ||
|
|
||
| @Override |
angelmp01
reviewed
Mar 26, 2026
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
Contributor
There was a problem hiding this comment.
remove this method as well
angelmp01
reviewed
Mar 26, 2026
| return true; | ||
| } | ||
|
|
||
| private Map<ComposedId, Component> mockComponentsCache = Collections.synchronizedMap(new HashMap<>()); |
Contributor
There was a problem hiding this comment.
avoid to use synchro methods!
angelmp01
reviewed
Mar 26, 2026
| Component mockComponent = new Component(); | ||
| mockComponent.setId(generateNextId()); | ||
| mockComponent.setName("Mock Component " + mockComponent.getId() + " for project " + projectId); | ||
| synchronized (mockComponentsCache) { |
Contributor
There was a problem hiding this comment.
avoid to use synchronized blocks!
angelmp01
reviewed
Mar 26, 2026
| @Service | ||
| @AllArgsConstructor | ||
| @Slf4j | ||
| public class ComponentMockService implements ExternalService { |
Contributor
There was a problem hiding this comment.
you can name this class ComponentService
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
|
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mocks for create/get component and fix REST paths.