-
Notifications
You must be signed in to change notification settings - Fork 3
Cleaning up #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the simulation run management in the SimulationExperimentView by consolidating the live run into the same array as regular runs, along with minor UI improvements and version updates.
Changes:
- Refactored run management to treat the live run as the first element (index 0) in the runs array, simplifying the codebase
- Updated UI styling including button sizes, color selection indicator, and spacing adjustments
- Added URL decoding for file tab names in ContentsComponent
- Bumped version numbers to 0.20260119.0
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/renderer/src/components/views/SimulationExperimentView.vue | Refactored run management to consolidate live run with regular runs, updated UI elements, and simplified popover handling |
| src/renderer/src/components/ContentsComponent.vue | Added decodeURIComponent to properly display URL-encoded file names in tabs |
| src/renderer/package.json | Version bump to 0.20260119.0 |
| package.json | Version bump to 0.20260119.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…her. This removes some duplicated code.
… multiple run support. - Highlight the selected run colour with a thick border instead of a tick. - Keep the colour popover open so that we can test different colours in one go. - Fixed the width of the show/hide and remove buttons.
dfdc01d to
91d9163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.