-
Notifications
You must be signed in to change notification settings - Fork 555
Link Layer Retry support in SAI. #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
59e0bc1 to
bfb4046
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bfb4046 to
e0ec34b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rck-innovium Please check in the Waiver Form for non UEC Members who would like to review the PR.
Each reviewer if not a UEC member, MUST sign the waiver form. Signed waiver form will be committed as part of the PR commit process for audit trail purposes.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JaiOCP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
j-bos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but one whitespace item to address (may affect metadata build)
inc/saiport.h
Outdated
| SAI_LLR_FRAME_ACTION_BLOCK, | ||
|
|
||
| /** Frames are treated as regular packets and are transmitted. */ | ||
| SAI_LLR_FRAME_ACTION_BEST_EFFORT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra comma
Refer: Chapter 5.1 of https://ultraethernet.org/wp-content/uploads/sites/20/2025/06/UE-Specification-6.11.25.pdf Signed-off-by: rck-innovium <rck@marvell.com>
e0ec34b to
eb3aa1d
Compare
Link Layer Retry support in SAI based on Ultra Ethernet Consortium spec 1.0 Chapter 5.1.
Note:
Please refer: #2226