Skip to content

Conversation

@marian-pritsak
Copy link
Contributor

@marian-pritsak marian-pritsak commented Jun 10, 2025

Add flow bulk get event callback
to notify of the state change
in bulk sync.

@r12f
Copy link
Contributor

r12f commented Jun 29, 2025

hi @marian-pritsak , are these ones generated but missed committing to SAI?

@marian-pritsak
Copy link
Contributor Author

hi @marian-pritsak , are these ones generated but missed committing to SAI?

They are created manually because they are not part of CRUD APIs.

@vivekrnv
Copy link
Contributor

vivekrnv commented Sep 5, 2025

@prsunny, @r12f Can you help signoff this PR?

@prsunny
Copy link
Collaborator

prsunny commented Sep 26, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KrisNey-MSFT
Copy link

@prsunny or @prabhat to merge please

@KrisNey-MSFT
Copy link

too old, @marian-pritsak to rebase branch to trigger pipeline

@marian-pritsak
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2175 in repo opencomputeproject/SAI

@zjswhhh
Copy link

zjswhhh commented Oct 30, 2025

Hi @tjchadaga - can you help merge please? Thanks!

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Collaborator

@marian-pritsak - could you please rebase your branch to the latest and squash your commits for the metachecker to pass?

@marian-pritsak
Copy link
Contributor Author

@tjchadaga can you please re-run? The commit was rebased to master.

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Add flow bulk get event callback and supporting
structures to provide ability to query flows
in asynchronous manner.

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Collaborator

prsunny commented Nov 13, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Collaborator

prsunny commented Nov 13, 2025

@marian-pritsak , there is a build failure. Can you check on this?

g++ -I../inc -I../experimental -I../custom -fPIC -ansi -Wall -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Werror -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Winline -Winvalid-pch -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wshadow -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wwrite-strings -std=c++11 -Wno-return-type -c generated/gen-cpp/sai_constants.cpp -o generated/gen-cpp/sai_constants.o
In file included from generated/gen-cpp/sai_constants.h:10,
                 from generated/gen-cpp/sai_constants.cpp:7:
generated/gen-cpp/sai_types.h:2509:27: error: field 'flow_entry' has incomplete type 'sai::sai_thrift_flow_entry_t'
 2509 |   sai_thrift_flow_entry_t flow_entry;
      |                           ^~~~~~~~~~
In file included from generated/gen-cpp/sai_constants.h:10,
                 from generated/gen-cpp/sai_constants.cpp:7:
generated/gen-cpp/sai_types.h:1128:7: note: forward declaration of 'class sai::sai_thrift_flow_entry_t'
 1128 | class sai_thrift_flow_entry_t;
      |       ^~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:178: generated/gen-cpp/sai_constants.o] Error 1

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
@prsunny
Copy link
Collaborator

prsunny commented Dec 15, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit e6d287c into opencomputeproject:master Dec 15, 2025
3 checks passed
pullaraogunda pushed a commit to pullaraogunda/SAI that referenced this pull request Dec 16, 2025
…t#2175)

* [DASH] Add flow bulk get session event data struct

Add flow bulk get event callback and supporting
structures to provide ability to query flows
in asynchronous manner.
JaiOCP added a commit to JaiOCP/SAI that referenced this pull request Dec 19, 2025
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Port and Switch Attributes

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG ACL Attributes

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG TAM Attributes

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Time Interval Unit

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Document

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Document

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Document

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

Fix: "INVAILD" typo in enum '_sai_dash_flow_entry_bulk_get_session_filter_key_t' (opencomputeproject#2224)

This PR fixes a typo in the enum definition for dash_flow_entry_bulk_get_session_filter_key_t where the member INVAILD is corrected to INVALID.

Changes:

saitypesextensions.h: Renamed enum member INVAILD → INVALID.
Following will be pushed to DASH's repo once these SAI repo changes are merged.

dash_headers.p4: Renamed enum member INVAILD → INVALID.

Non UEC Member Agreement Form (opencomputeproject#2226)

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

Seamless BFD (S-BFD) (opencomputeproject#2220)

Signed-off-by: Jason Bos <jbos@cisco.com>

Replicate VXLAN UDP sport security to switch level (opencomputeproject#2195)

- Add SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY attribute to drop tunnel packets with UDP source port outside allowed range
- Add documentation for UDP source port validation on VXLAN packet ingress
- Update both saiswitch.h and saitunnel.h with security clarifications

Signed-off-by: Marian Pritsak <marianp@mellanox.com>

SRv6 SID Marking (opencomputeproject#2222)

* SID Marking APIs

Signed-off-by: Jason Bos <jbos@cisco.com>

[DASH] Add flow bulk get session event data struct (opencomputeproject#2175)

* [DASH] Add flow bulk get session event data struct

Add flow bulk get event callback and supporting
structures to provide ability to query flows
in asynchronous manner.

Introducing SAI_PORT_ATTR_PORT_PG_PKT_DROP_STATUS (opencomputeproject#2234)

In this map, the key is the PG index and the status value (clear-on-read)
for each PG is from {0, 1}, where 0 indicates no drops were observed and 1
indicates packet drops.

Signed-off-by: Prasun Sinha <prasunsinha@google.com>

Add flow entry to the bulk session event data (opencomputeproject#2237)

Add the ability to query the flows with the
bulk get session event data callback.

The commit contains a fix for bad ordering of
classes generated by Thrift compiler for the nested
structures used in this callback.

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
tjchadaga pushed a commit that referenced this pull request Jan 2, 2026
* [DASH] Add flow bulk get session event data struct

Add flow bulk get event callback and supporting
structures to provide ability to query flows
in asynchronous manner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants