fix: prevent components from being proxied in Vue's reactivity system#2588
Open
JammingBen wants to merge 1 commit into
Open
fix: prevent components from being proxied in Vue's reactivity system#2588JammingBen wants to merge 1 commit into
JammingBen wants to merge 1 commit into
Conversation
Vue warns when a component object is made reactive, which can cause performance overhead and interfere with component identity checks. Components passed as `content` to extension registrations and as `customComponent` to `dispatchModal` calls were missing markRaw, causing them to be inadvertently proxied by Vue's reactivity system.
JammingBen
changed the title
JammingBen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vue warns when a component object is made reactive, which can cause performance overhead and interfere with component identity checks. Components passed as
contentto extension registrations and ascustomComponenttodispatchModalcalls were missingmarkRaw, causing them to be inadvertently proxied by Vue's reactivity system.