add extra extensions to text editor app#2512
Open
tralph3 wants to merge 1 commit into
Open
Conversation
JammingBen
approved these changes
May 19, 2026
Member
JammingBen
left a comment
There was a problem hiding this comment.
Looks good, thanks!
I'm waiting for the merge because we're currently in a hardening sprint for the upcoming stable release and this is technically a feature. I'll merge it once we have a stable branch.
In the future, maybe it'd be better to rely on a text detection method, rather than extensions.
I agree. The issue is that we need to rely on information the server gives us in the PROPFIND. Any (potentially expensive) text detection wouldn't work. Still, there are better ways to do this than via the file extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds more extensions to the file manager app. The previous selection was quite sparse, leaving out a lot of common files. These additions should make it more universal. In the future, maybe it'd be better to rely on a text detection method, rather than extensions.
Types of changes