Open
Conversation
JammingBen
reviewed
Apr 7, 2026
Member
JammingBen
left a comment
There was a problem hiding this comment.
I'm noticing a few small things:
- The horizontal padding to the sides feels a bit too big. I think it should be
16pxin total, just like the files details root panel. It seems to be24pxfor the shares. - The 3-dots-menu next to the "Share" button is missing a hover.
- The "Search" placeholder inside the invite input is jumping on focus.
- The role select ("Can view") beneath the invite input and the "Add link" button now have a visible hover, maybe set
no-hover? Because it looks a bit off without any margin. - Something happened to the paddings of the link and people share menus, they're too big, especially top:
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
Outdated
Show resolved
Hide resolved
JammingBen
approved these changes
Apr 7, 2026
….vue Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
…s.vue Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes