fix(web-runtime): cache embed query params across config reloads#1977
Open
dschmidt wants to merge 1 commit intoopencloud-eu:next-release/stable-4.2from
Open
fix(web-runtime): cache embed query params across config reloads#1977dschmidt wants to merge 1 commit intoopencloud-eu:next-release/stable-4.2from
dschmidt wants to merge 1 commit intoopencloud-eu:next-release/stable-4.2from
Conversation
announceConfiguration is called twice: once during bootstrap and again
when userContextReady fires. By the second call the delegated-auth
callback has navigated away from the initial /?embed=true&… URL, so
getQueryParam('embed') returns null and embed mode is silently disabled.
Cache the derived embed config on the first call and return the snapshot
on subsequent invocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
announceConfiguration is called twice: once during bootstrap and again when userContextReady fires. By the second call the delegated-auth callback has navigated away from the initial /?embed=true&… URL, so getQueryParam('embed') returns null and embed mode is silently disabled.
Cache the derived embed config on the first call and return the snapshot on subsequent invocations.
Related Issue
How Has This Been Tested?
It's hard to setup a reproduction environment for this and also it's very late ... let's talk about it tomorrow
Types of changes