fix(web-pkg): guard against missing routes in getEditorRoute#1975
Open
dschmidt wants to merge 1 commit intoopencloud-eu:next-release/stable-4.2from
Open
fix(web-pkg): guard against missing routes in getEditorRoute#1975dschmidt wants to merge 1 commit intoopencloud-eu:next-release/stable-4.2from
dschmidt wants to merge 1 commit intoopencloud-eu:next-release/stable-4.2from
Conversation
Apps can register file extensions without defining routes (e.g. for icon association only). After the vue-router v5 upgrade, router.resolve() throws on non-existent route names instead of failing silently. This caused a crash when listing folders containing files handled by such apps. Check router.hasRoute() before calling router.resolve() to prevent the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apps can register file extensions without defining routes (e.g. for icon association only). After the vue-router v5 upgrade, router.resolve() throws on non-existent route names instead of failing silently. This caused a crash when listing folders containing files handled by such apps.
Check router.hasRoute() before calling router.resolve() to prevent the error.
Related Issue
How Has This Been Tested?
Types of changes