add additional validation to logout token#2328
add additional validation to logout token#2328dragonchaser wants to merge 5 commits intoopencloud-eu:mainfrom
Conversation
dragonchaser
force-pushed
the
fix-backchannel-logout
branch
from
a5ff70e to
8cd6107
Compare
dragonchaser
force-pushed
the
fix-backchannel-logout
branch
from
8cd6107 to
c051e6e
Compare
fschade
force-pushed
the
fix-backchannel-logout
branch
from
c67804e to
6f8c92f
Compare
|
toDo:
|
fschade
force-pushed
the
fix-backchannel-logout
branch
2 times, most recently
from
a10347c to
ae9427a
Compare
| logger.Error().Err(err).Msg("Error reading userinfo cache") | ||
|
|
||
| // the map will contain the record references that are needed for the logout. | ||
| // - nil value means: subject or claim record |
There was a problem hiding this comment.
i understand what a subject and sid record is. But what is a claim record?
There was a problem hiding this comment.
i understand what a
subjectandsidrecord is. But what is aclaimrecord?
the claim record contains the claim as []byte, e.g.:
https://github.com/dragonchaser/opencloud/blob/1e53cc92969ca56b3071211e189405615d398ced/services/proxy/pkg/middleware/oidc_auth.go#L110
the value is needed for the backchannel logout event for GetUserByClaims, e.g.:
https://github.com/dragonchaser/opencloud/blob/1e53cc92969ca56b3071211e189405615d398ced/services/proxy/pkg/staticroutes/backchannellogout.go#L160
the existing token cant be used because one subject could contain multiple sessions with one token each....
Signed-off-by: Christian Richter <c.richter@opencloud.eu> Co-authored-by: Michael Barz <m.barz@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Co-authored-by: Jörn Dreyer <j.dreyer@opencloud.eu> Co-authored-by: Michael Barz <m.barz@opencloud.eu> Signed-off-by: Christian Richter <c.richter@opencloud.eu>
fschade
force-pushed
the
fix-backchannel-logout
branch
from
ae9427a to
1e53cc9
Compare
|
|
A few minor things here and there, but it should be fine for now. logout.mp4 |
3 participants
refs https://github.com/opencloud-eu/internal/issues/246