Skip to content

Conversation

@fschade
Copy link
Contributor

@fschade fschade commented Dec 18, 2025

Description

the edition validation does not mention the configured edition (go build flag) which results in:

{"level":"error","error":"unknown edition channel 'dev'","time":"2025-12-18T12:56:14.607885675Z","caller":"github.com/opencloud-eu/opencloud/pkg/version/version.go:55","message":"falling back to dev"}

Motivation and Context

if a configured edition is not allowed the error should mention the used edition, e.g.

{"level":"error","error":"unknown edition channel 'foo'","time":"2025-12-18T12:56:14.607885675Z","caller":"github.com/opencloud-eu/opencloud/pkg/version/version.go:55","message":"falling back to dev"}

also, the current EDITION ARG in Dockerfile.multiarch has no default value which always results in a logged error if the edition is not provided.

How Has This Been Tested?

  • local docker builds
  • unit-tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@fschade fschade force-pushed the fix-edition-error-and-default branch from ae03bc9 to 48fab2a Compare December 19, 2025 11:14
@fschade fschade force-pushed the fix-edition-error-and-default branch from 48fab2a to dd4b36a Compare December 22, 2025 14:57
@fschade fschade self-assigned this Dec 22, 2025
@fschade fschade merged commit 19a8ff3 into opencloud-eu:main Dec 23, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants