-
Notifications
You must be signed in to change notification settings - Fork 159
merge ocdav into frontend #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a9f558d to
0947bf7
Compare
|
it seems reva handles a leading |
|
@ScharfViktor the tests were expecting the wrong status codes. I corrected them and CI should now become green. |
153516d to
2345e74
Compare
| } | ||
|
|
||
| type OCDav struct { | ||
| Prefix string `yaml:"prefix" env:"OCDAV_HTTP_PREFIX" desc:"A URL path prefix for the handler." introductionVersion:"1.0.0"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we introduce FRONTEND_OCDAV_* variables and deprecate the OCDAV_* ones for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather aim for dropping the service prefix. @rhafer proposed that and since we are deploying only one process in the compose stack and two or three in the helm chart, I agree. In this case OCDAV_ would match the handler, so I think reusing them is fine.
IIRC @dragonchaser is trying to reduce the number of env vars as well, so he might have an opinion as well.
a456971 to
afb8cbe
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
d4b2301 to
3099fb1
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
3099fb1 to
7f19839
Compare
This PR moves the ocdav handler back into the frontend. This removes one usage of the go micro service.