Skip to content

Conversation

@butonic
Copy link
Contributor

@butonic butonic commented Sep 22, 2025

While testing #1533 I wondered why this feature failed as well:

  @env-config @issue-10661
  Scenario: check extra services readiness
    Given the following configs have been set:
      | config                 | value        |
      | OC_ADD_RUN_SERVICES  | auth-bearer  |
      | AUTH_BEARER_DEBUG_ADDR | 0.0.0.0:9149 |
    When a user requests these URLs with "GET" and no authentication
      | endpoint                               | service     |
      | http://%base_url_hostname%:9149/readyz | auth-bearer |
    Then the HTTP status code of responses on all endpoints should be "200"

The auth-bearer service is not started when OC_ADD_RUN_SERVICES="auth-bearer". This pr changes that.

Maybe we should log an error if the config contains an unknown service?

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic self-assigned this Sep 22, 2025
@github-project-automation github-project-automation bot moved this to Qualification in OpenCloud Team Board Sep 22, 2025
@butonic butonic moved this from Qualification to In Progress in OpenCloud Team Board Sep 22, 2025
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As auth-bearer can't do anything useful for us in the current shape, we should not allow to run it (even for testing)

@butonic
Copy link
Contributor Author

butonic commented Sep 22, 2025

then we should delete the code

@rhafer
Copy link
Contributor

rhafer commented Sep 23, 2025

either that or finally make it useful again (#897)

@rhafer rhafer moved this from In Progress to Blocked in OpenCloud Team Board Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Blocked

Development

Successfully merging this pull request may close these issues.

3 participants