Localization Update: New Structure + German Support! 🇩🇪#39
Conversation
Removed untranslated section markers and added new translations.
Removed untranslated sections from Localizable.xcstrings.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hello, out of curiosity, did you use AI to generate the translation ? (I would like to add a french translation and I am considering doing it with AI once this is merged) |
|
It was a combination: the Apple documentation and the existing English version were used as a basis. The translation was created using AI and then adapted to my requirements. In some cases, the translations were not entirely accurate and the syntax had issues, so manual adjustments were necessary. However, with this change, new translations should be able to be integrated more quickly. |
|
@cryinkfly thank you for your pull request ❤️ and sorry for the late response. @guruz could you please look into this? Additionally, similar to the android app, we want to manage translations in our transifex.com project. Is it possible to import the translations from this PR into transifex? |
|
Thank you and sorry for delay. I'm looking into this. Thank you for the translations. I'll check how we best do it.. |
|
@cryinkfly 's translations are up now in https://testflight.apple.com/join/2F5wWTGV build. I will post info later today about the transifex integration and how people can add more translations there (still need to sort out some stuff in build process and github..) |
|
@guruz I’ve installed this version, and it appears to be working well so far. I’ll be putting it through its paces over the coming days. 💪
|
|
I've cherry-picked this PR into #46 .. closing here. Translations are on transifex now: https://app.transifex.com/opencloud-eu/opencloud-eu/content/ |
This would be appreciated, however i have no idea how to do this with Transifex. Maybe you can dowload the un-translated french there, translate it and re-upload it there (at transifex, not here in GitHub)? |
|
I will have a look and see what I can do! |
|
@guruz I uploaded the translation on Transifex. I did it with AI, then reviewed it quickly. Had to make some corrections but most of it was already good. I am unsure of some translation by lack of some context sometimes, but I would say it is 99.5 % good and usable in production. |
|
Great! That is exactly how we will eliminate language barriers and enable as many people as possible to access such a wonderful solution! 💪 |
Description
I restructured the Localizable.xcstrings file to improve maintainability and make future translations faster and easier to manage. Additionally,
German (de) translationswere addedfor all existing English (en) strings.Related Issue
No specific issue was linked. This is an enhancement to improve localization workflow and support German language.
Motivation and Context
Previously, the
Localizable.xcstringsstructure made adding new translations cumbersome and error-prone. By restructuring it, new languages can be added more quickly, and future updates will be easier to maintain. The addition of German provides broader accessibility for German-speaking users.How Has This Been Tested?
Verified that the Localizable.xcstrings file remains valid JSON and parses correctly.
Loaded the app in both English and German to ensure all strings display correctly.
Checked that there are no missing or broken entries for existing keys.
Screenshots (if appropriate):
Not applicable; changes are internal to the localization files.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
My code follows the code style of this project.
My change requires a change to the documentation.
Added an issue with details about all relevant changes in the docs repository.
I have added tests to cover my changes (visual/manual verification for localization).
All new and existing tests passed.
I have set a pull request label and a meaningful title for changelog automation.