fix(endpoints): resolve userId from userLogin in DELETE__delete_user#11
Closed
michaelstingl wants to merge 1 commit intoopencloud-eu:mainfrom
Closed
fix(endpoints): resolve userId from userLogin in DELETE__delete_user#11michaelstingl wants to merge 1 commit intoopencloud-eu:mainfrom
michaelstingl wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
LibreGraph API requires UUID for user deletion, not username. Added GET__get_users endpoint and auto-lookup in DELETE__delete_user when only userLogin is provided. Fixes opencloud-eu#10
Member
|
Thanks for the pointer, it’s fixed here: I do t like to have the user lookup inside the delete user function, it will increase the requests which makes measuring the results hard! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DELETE__delete_useruseduserLogin(username) in the URL path, but LibreGraph API requires the user's UUID. This caused 404 errors when deleting users via_seeds-down-k6.js.Fix: Add
GET__get_usersendpoint and auto-resolve UUID from username inDELETE__delete_userif onlyuserLoginis provided.Only
graph-v1-users.tsis changed. No changes to client or test files needed. Backwards compatible - existing callers using{ userLogin }continue to work.Related Issue
How Has This Been Tested?
pnpm buildpassesk6 run _seeds-up-k6.js- 100% checks passed (764/764)k6 run _seeds-down-k6.js- 100% checks passed (10/10), including✓ client -> user.deleteUser - statusBefore (from issue #10):
After (Loki access logs):
Types of changes