Allow Node Sandbox opt-out on unsupported Windows builds (restore host execution path)#496
Closed
Copilot wants to merge 2 commits into
Closed
Allow Node Sandbox opt-out on unsupported Windows builds (restore host execution path)#496Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: shanselman <2892+shanselman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Node Sandbox blocking commands on Windows 10 build 19044
Allow Node Sandbox opt-out on unsupported Windows builds (restore host execution path)
May 21, 2026
Contributor
|
will use #487 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows 10 build 19044, MXC sandboxing is unavailable, and the current behavior blocks all
host=nodecommand execution with no user override. This change restores a safe/explicit opt-out path: keep fail-closed when sandbox is enabled, but allow unsandboxed execution when users turn sandbox off.Runtime gating (
MxcCommandRunner)SystemRunSandboxEnabled == false→ route to host runner, even if MXC is unavailable.SystemRunSandboxEnabled == true && MXC unavailable→ deny execution (fail closed) with updated guidance text.Sandbox UX on unsupported systems (
SandboxPage)Behavioral test update
MxcCommandRunnerunit coverage to assert host routing when MXC is unavailable and sandbox is turned off.