Fix WebSocket lifecycle responsiveness#443
Open
shanselman wants to merge 1 commit into
Open
Conversation
Serialize outbound WebSocket sends, propagate connection cancellation, and move node invoke execution off the receive loop with bounded dispatch. Add regression coverage for send serialization, dispatch responsiveness, and lifecycle cancellation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientWebSocket.SendAsynccollisions.GatewayConnectionManagerthroughGatewayClientFactoryintoWebSocketClientBase, with captured-socket listen loops and generation guards for stale lifecycle work.Felt-performance/correctness risk addressed
This prevents receive loops from being blocked by long-running node capabilities, prevents fire-and-forget request sends from colliding, and avoids stale connect/reconnect work updating gateway or node state after cancellation/disconnect.
Validation
./build.ps1dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restoredotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restoredotnet test ./tests/OpenClaw.Connection.Tests/OpenClaw.Connection.Tests.csproj