Harden deep-link IPC handling#441
Merged
Merged
Conversation
Scope the deep-link named pipe to the current Windows user/session, bound IPC payload reads, redact sensitive URI data from logs, and require confirmation before state-changing deep links execute. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PipeOptions.CurrentUserOnlyon the pipe connection.send,agent,voice,voice-stop, SSH restart aliases) execute while preserving benign navigation/config/help links.Security/privacy impact
This addresses the high-consensus finding that a predictable pipe plus unbounded forwarded payloads could allow local cross-user/session IPC abuse or leak sensitive URI contents such as messages, tokens, and query strings in logs. The pipe is now scoped to the active user/session/data directory, payloads are bounded, logs are redacted, and state-changing links require user approval.
User impact
Benign deep links continue to navigate/open diagnostic surfaces without prompts. Deep links that can change state now show an Allow/Cancel confirmation before running.
Validation
./build.ps1dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore— 1795 total, 0 failed, 1767 passed, 28 skippeddotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore— 1066 total, 0 failed, 1066 passed