Fix README-testing.md instructions #696
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the local Docker testing setup by ensuring the PHP test container runs in the repository root (
/var/www/public) and by documenting the missing dependency installation step for fresh checkouts.It adds
working_dir: /var/www/publicto thephpservice indocker/docker-compose-test.ymland updatesREADME-testing.mdto instruct users to runcomposer install(via a Composer Docker image) so thevendor/directory and./vendor/bin/phpunitare available.Motivation
Following
README-testing.mdon a fresh checkout can currently fail becausevendor/is not committed and therefore./vendor/bin/phpunitdoes not exist until Composer dependencies are installed.Additionally, the PHP test container’s default working directory may not be the repository mount path, causing relative commands in the README to fail even after installing dependencies.
These changes make the testing instructions work out of the box for new contributors and reduce confusion when running PHPUnit/Behat inside the test container.