Skip to content

feat: comments #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bennit99 wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: comments #1685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
af82f70
feat: comments
Bennit99 Mar 2, 2026
2dd6ba9
chore: configure vite dev proxy to bypass CORS
Bennit99 Mar 2, 2026
c1ec721
Revert "chore: configure vite dev proxy to bypass CORS"
Bennit99 Mar 22, 2026
0f6e182
comments flag set to false by default
Bennit99 Mar 22, 2026
40f554a
remove optional chaining from settings.comments
Bennit99 Mar 22, 2026
1c1eaa6
Merge branch 'develop' of github.com:Bennit99/opencast-editor into de…
Bennit99 Mar 22, 2026
72ae507
use displayName for UI
Bennit99 Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions public/editor-settings.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,6 @@ spanish = { lang = "es" }

[thumbnail]
show = true

[comments]
show = false
Copy link
Copy Markdown
Member

@gregorydlogan gregorydlogan Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be true, since this config is what's backing editor.opencast.org and we want to show off all of the bells and whistles.

9 changes: 9 additions & 0 deletions src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ interface iSettings {
mainFlavor: string,
defaultVideoFlavor: Flavor | undefined,
};
comments: {
show: boolean,
},
}

/**
Expand Down Expand Up @@ -124,6 +127,9 @@ const defaultSettings: iSettings = {
mainFlavor: "chapters",
defaultVideoFlavor: undefined,
},
comments: {
show: false,
},
};
let configFileSettings: iSettings;
let urlParameterSettings: iSettings;
Expand Down Expand Up @@ -430,6 +436,9 @@ const SCHEMA = {
show: types.boolean,
simpleMode: types.boolean,
},
comments: {
show: types.boolean,
},
};

const merge = (a: iSettings, b: iSettings) => {
Expand Down
4 changes: 2 additions & 2 deletions src/cssStyles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export const basicButtonStyle = (theme: Theme) => css({
* CSS for deactivated buttons
*/
export const deactivatedButtonStyle = css({
borderRadius: "10px",
borderRadius: "5px",
cursor: "pointer",
opacity: "0.6",
// Flex position child elements
Expand All @@ -83,7 +83,7 @@ export const deactivatedButtonStyle = css({
});

/**
* CSS for nagivation styled buttons
* CSS for navigation styled buttons
*/
export const navigationButtonStyle = (theme: Theme) => css({
width: "200px",
Expand Down
44 changes: 43 additions & 1 deletion src/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"chapters-button": "Chapters",
"thumbnail-button": "Thumbnail",
"metadata-button": "Metadata",
"comments-button": "Comments",
"keyboard-controls-button": "Keyboard Controls",
"tooltip-aria": "Main Navigation"
},
Expand Down Expand Up @@ -246,7 +247,8 @@
"error-text": "An error has occurred. Please wait a bit and try again.",
"goBack-button": "No, take me back",
"callback-button-system": "Back to {{system}}",
"callback-button-generic": "Back to previous system"
"callback-button-generic": "Back to previous system",
"loading": "Loading..."
},

"trackSelection": {
Expand Down Expand Up @@ -331,6 +333,46 @@
"editTitle": "Chapter Editor"
},

"comments": {
"no-comments": "No comments yet. Be the first to comment!",
Copy link
Copy Markdown
Member

@Arnei Arnei Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make sense for a social media post or similar, but there is no reason to incentivize posting comments in Opencast. I think "No comments yet." is enough.

"resolved": "Resolved",
"open": "Open",
"reply": "Reply",
"delete": "Delete",
"add-comment": "Add Comment",
"placeholder": "Write your comment...",
"select-reason": "Select a reason...",
"submit": "Submit",
"saving": "Saving...",
"reply-to": "Reply to",
"reply-placeholder": "Write your reply to",
"mark-resolved": "Mark as resolved",
"cancel": "Cancel",
"pending": "Pending",
"pending-tooltip": "Pending changes need to be saved in the Finish tab.",
"reasons": {
"cutting": "Cutting required",
"review": "Review required",
"async": "A/V tracks asynchronous",
"audio_issue": "Missing or defective audio track",
"cancelled": "Canceled event",
"conflicting_metadata": "Conflicting metadata",
"improper_point": "Improper in or out point",
"missing_agreement": "Missing agreement",
"other": "Other",
"privacy": "Privacy concern",
"segmentation": "Inaccurate segmentation",
"unknown_creator": "Creator unknown",
"video_issue": "Video distorted or cropped",
"wrong_input_format": "Input file format not supported",
"wrong_metadata": "Metadata needs correction",
"wrong_series_publication": "Wrong series or publication channel",
"wrong_workflow": "Wrong workflow",
"processing_failure": "Processing failure",
"admin_ui_notes": "Notes in Admin UI"
Copy link
Copy Markdown
Member

@Arnei Arnei Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be adminui_notes?

}
},

"keyboardControls": {
"header": "Shortcuts",
"defaultGroupName": "General",
Expand Down
Loading
Loading