Skip to content

Fixing more a11y issues in the create event dialog #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arnei wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −4
Open

Fixing more a11y issues in the create event dialog #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,10 @@ const Upload = <T extends RequiredFormPropsUpload>({
formik.values.uploadAssetsTrack.map((asset, key) => (
<tr key={key}>
<td>
<span className="title">
<span id={`asset-title-${asset.id}`} className="title">
{translateOverrideFallback(asset, t, "SHORT")}
</span>
<p>
<p id={`asset-desc-${asset.id}`}>
{translateOverrideFallback(asset, t, "DETAIL")}
</p>
</td>
Expand Down Expand Up @@ -310,6 +310,9 @@ const Upload = <T extends RequiredFormPropsUpload>({
onChange={e =>
handleChange(e, `uploadAssetsTrack.${key}.file`)
}
tabIndex={0}
aria-labelledby={`asset-title-${asset.id}`}
aria-describedby={`asset-desc-${asset.id}`}
/>
</div>
</td>
Expand All @@ -324,6 +327,7 @@ const Upload = <T extends RequiredFormPropsUpload>({
);
(document.getElementById(asset.id) as HTMLInputElement).value = "";
}}
aria-label={t("EVENTS.EVENTS.NEW.SOURCE.UPLOAD.ARIA_REMOVE_FILE")}
>
<LuCircleX />
</ButtonLikeAnchor>
Expand Down
1 change: 1 addition & 0 deletions src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
arrayHelpers.remove(formik.values.policies.findIndex(p => p === policy))
}
className="action-cell-button remove"
aria-label={t("EVENTS.EVENTS.DETAILS.ACCESS.ROLES.ARIA_REMOVE_ROLE")}
>
<LuCircleX />
</ButtonLikeAnchor>
Expand Down
6 changes: 4 additions & 2 deletions src/i18n/org/opencastproject/adminui/languages/lang-en_US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,8 @@
"SUBTITLES": {
"SHORT": "Subtitles",
"DETAIL": "A subtitle file in vtt format"
}
},
"ARIA_REMOVE_FILE": "Remove uploaded file"
},
"DATE_TIME": {
"CAPTION": "Schedule",
Expand Down Expand Up @@ -920,7 +921,8 @@
"SANITIZATION_NOTE": "User role sanitization is enabled in your Opencast, therefore user roles are displayed alongside other roles. This does not impact role functionality in any way."
},
"ROLES": {
"LABEL": "Select or create a role"
"LABEL": "Select or create a role",
"ARIA_REMOVE_ROLE": "Remove this role"
}
},
"COMMENTS": {
Expand Down
Loading