Open
Conversation
Various dropdown (Table filters, workflow selector, pretty much everything in the ACL tab) would seemingly randomly have their focus reset to the top element every couple of seconds. This would make them hard or even impossible to navigate by users. This patch aims to fix that. The culprit here is a selector hook at the app level. The `Stats` component (the various numbers next to the "Add Event" button) would trigger this hook about every 5 seconds, causing the whole app to rerender and the dropdowns to reset focus. The proposed solution is to not use a selector. This will make our custom hook `useTableFilterStateValidation` effectively only run once on page load. I would argue this is fine, as we do not expect the state to corrupt while the app is running and thus don't need to check for corrupt state everytime the state changes.
Moves the code for fetching table info and filters from `TablePage` into `Table` and `TableFilters`. The goal here is to prevent the fetching code from rerendering unrelate components in `TablePage`.
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1506.
Various dropdown (Table filters, workflow selector, pretty much everything in the ACL tab) would seemingly randomly have their focus reset to the top element every couple of seconds. This would make them hard or even impossible to navigate by users. This patch aims to fix that.
The culprit here is a selector hook at the app level. The
Statscomponent (the various numbers next to the "Add Event" button) would trigger this hook about every 5 seconds, causing the whole app to rerender and the dropdowns to reset focus.The proposed solution is to not use a selector. This will make our custom hook
useTableFilterStateValidationeffectively only run once on page load. I would argue this is fine, as we do not expect the state to corrupt while the app is running and thus don't need to check for corrupt state everytime the state changes.Also moves the code for fetching table info and filters from
TablePageintoTableandTableFilters.The goal here is to prevent the fetching code from rerendering unrelate components in
TablePage.How to test this
Can be tested as is.