OBPIH-7534 Putaway when preferred bin assigned to inventory level#73
Merged
alannadolny merged 5 commits intomainfrom Feb 18, 2026
Merged
OBPIH-7534 Putaway when preferred bin assigned to inventory level#73alannadolny merged 5 commits intomainfrom
alannadolny merged 5 commits intomainfrom
Conversation
alannadolny
reviewed
Feb 16, 2026
Comment on lines
+19
to
+21
| return this.modal.locator( | ||
| 'select[name="preferredBinLocation"] + .chosen-container' | ||
| ); |
Collaborator
There was a problem hiding this comment.
Isn't there a better selector?
Collaborator
Author
There was a problem hiding this comment.
Could be if you add one :)
Collaborator
There was a problem hiding this comment.
Can we create a ticket for identifying all of those invalid selectors and changing them in both repos?
Comment on lines
+22
to
+33
|
|
||
| get confirmPutawayDialog() { | ||
| return this.page.locator('.react-confirm-alert'); | ||
| } | ||
|
|
||
| get yesButtonOnConfirmPutawayDialog() { | ||
| return this.confirmPutawayDialog.getByRole('button', { name: 'Yes' }); | ||
| } | ||
|
|
||
| get noButtonOnConfirmPutawayDialog() { | ||
| return this.confirmPutawayDialog.getByRole('button', { name: 'No' }); | ||
| } |
Collaborator
There was a problem hiding this comment.
Shouldn't the dialog be a separated class?
Collaborator
Author
There was a problem hiding this comment.
we also use it in similar way in other places
alannadolny
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created tests:
and