Skip to content

fix: isolate diff tests from local dotfiles repo state #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fullstackjam merged 4 commits into from
Apr 1, 2026
Merged

fix: isolate diff tests from local dotfiles repo state #22

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed44eee
fix: check all git config scopes, not just --global
Mar 29, 2026
7db09da
test: add test for git config scope fallback
Mar 29, 2026
7d6fec4
fix: don't check dotfiles repo state when URLs are empty
Mar 29, 2026
e3fd135
fix: isolate diff tests via HOME env instead of production code guards
jerryjrxie Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions internal/diff/compare_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,29 @@
package diff

import (
"os/exec"
"path/filepath"
"testing"

"github.com/openbootdotdev/openboot/internal/config"
"github.com/openbootdotdev/openboot/internal/snapshot"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

// isolateHome sets HOME to a temp directory with a clean .dotfiles git repo,
// so tests that call diffDotfiles() don't depend on the developer's local state.
func isolateHome(t *testing.T) {
t.Helper()
tmpDir := t.TempDir()
t.Setenv("HOME", tmpDir)
dotfiles := filepath.Join(tmpDir, ".dotfiles")
cmd := exec.Command("git", "init", dotfiles)
require.NoError(t, cmd.Run())
}

func TestCompareSnapshots_Identical(t *testing.T) {
isolateHome(t)
snap := &snapshot.Snapshot{
Packages: snapshot.PackageSnapshot{
Formulae: []string{"git", "curl"},
Expand All @@ -33,6 +48,7 @@ func TestCompareSnapshots_Identical(t *testing.T) {
}

func TestCompareSnapshots_PackageDifferences(t *testing.T) {
isolateHome(t)
system := &snapshot.Snapshot{
Packages: snapshot.PackageSnapshot{
Formulae: []string{"git", "wget"},
Expand All @@ -58,6 +74,7 @@ func TestCompareSnapshots_PackageDifferences(t *testing.T) {
}

func TestCompareSnapshots_MacOSDifferences(t *testing.T) {
isolateHome(t)
system := &snapshot.Snapshot{
MacOSPrefs: []snapshot.MacOSPref{
{Domain: "NSGlobalDomain", Key: "AppleShowAllExtensions", Value: "true"},
Expand All @@ -83,6 +100,7 @@ func TestCompareSnapshots_MacOSDifferences(t *testing.T) {
}

func TestCompareSnapshots_DevToolDifferences(t *testing.T) {
isolateHome(t)
system := &snapshot.Snapshot{
DevTools: []snapshot.DevTool{
{Name: "go", Version: "1.22"},
Expand Down Expand Up @@ -111,6 +129,7 @@ func TestCompareSnapshots_DevToolDifferences(t *testing.T) {
}

func TestCompareSnapshotToRemote(t *testing.T) {
isolateHome(t)
system := &snapshot.Snapshot{
Packages: snapshot.PackageSnapshot{
Formulae: []string{"git", "wget"},
Expand Down Expand Up @@ -141,6 +160,7 @@ func TestCompareSnapshotToRemote(t *testing.T) {
}

func TestCompareSnapshotToRemote_EmptyRemote(t *testing.T) {
isolateHome(t)
system := &snapshot.Snapshot{
Packages: snapshot.PackageSnapshot{
Formulae: []string{"git"},
Expand All @@ -155,6 +175,7 @@ func TestCompareSnapshotToRemote_EmptyRemote(t *testing.T) {
}

func TestCompareSnapshots_MacOSExtraPrefs(t *testing.T) {
isolateHome(t)
system := &snapshot.Snapshot{
MacOSPrefs: []snapshot.MacOSPref{
{Domain: "com.apple.dock", Key: "autohide", Value: "true"},
Expand All @@ -177,6 +198,7 @@ func TestCompareSnapshots_MacOSExtraPrefs(t *testing.T) {
}

func TestCompareSnapshots_EmptySnapshots(t *testing.T) {
isolateHome(t)
system := &snapshot.Snapshot{}
reference := &snapshot.Snapshot{}

Expand Down
Loading