Fix useInfiniteQuery query key collision with useQuery#2671
Open
longzheng wants to merge 4 commits intoopenapi-ts:mainfrom
Open
Fix useInfiniteQuery query key collision with useQuery#2671longzheng wants to merge 4 commits intoopenapi-ts:mainfrom
longzheng wants to merge 4 commits intoopenapi-ts:mainfrom
Conversation
…ash with useQuery Co-authored-by: longzheng <484912+longzheng@users.noreply.github.com>
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: b05bbb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
useInfiniteQueryanduseQuerygenerate identical query keys for the same method/path/params, causing React Query cache collisions. SinceuseInfiniteQuerywraps data inInfiniteData<TData>whileuseQueryreturns plainTData, the shared cache entry causesTypeError: Cannot read properties of undefined (reading 'length')whengetNextPageParamtries to accessdata.pages.Appends
"infinite"to the query key tuple foruseInfiniteQuery, e.g.["get", "/api/test", init, "infinite"], so the two hooks maintain separate cache entries.Fixes #2184
How to Review
Added a test to reproduce query key collision and resulting error when loading data. Revert change to see test fail
return useInfiniteQuery( { - queryKey: [...queryKey, "infinite"], + queryKey,Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)