Fix optional bodies #1357
Closed
Fix optional bodies #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanty
commented
Nov 6, 2025
| _json: dict[str, Any] | Unset = UNSET | ||
| if not isinstance(body, Unset): | ||
| _json = body.to_dict() | ||
| _kwargs["json"] = _json |
Collaborator
Author
There was a problem hiding this comment.
Gotta move this under the if check
dbanty
force-pushed
the
fix-optional-bodies
branch
from
c39737d to
0b1c3c2
Compare
dbanty
commented
Nov 7, 2025
Comment on lines
19
to
23
| | Unset | ||
| | PostBodiesMultipleDataBody | ||
| | Unset | ||
| | PostBodiesMultipleFilesBody | ||
| | Unset = UNSET, |
Collaborator
Author
There was a problem hiding this comment.
Unions still aren't quite right. This shouldn't list Unset twice and in a different, local union test it was trying to call .to_dict() on an Unset
expobrain
force-pushed
the
fix-optional-bodies
branch
from
0b1c3c2 to
d538096
Compare
Merged
dbanty
added a commit
that referenced
this pull request
Dec 3, 2025
Reopening #1357 Co-authored-by: Dylan Anthony <dbanty@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1354