Conversation
…nalea/StructureAnalysis into 67-release-2025---structure-analysis
Update environment.yaml
pradal
left a comment
pradal
left a comment
There was a problem hiding this comment.
Good work.
Some comments to consider...
| file(GLOB HEADERS "*.h" "*.hpp") | ||
| file(GLOB SOURCES "*.cpp") | ||
|
|
||
| add_library(vpstat_tool STATIC ${SOURCES} ${HEADERS}) |
There was a problem hiding this comment.
Here, you need to build the lib as a shared library.
Replace static by dynamic
| endif() | ||
|
|
||
| # Add include directories | ||
| target_include_directories(vpstat_tool PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}) |
There was a problem hiding this comment.
You need to install the headers in $CONDA_PREFIX/include/stat_tool
And also the lib into $CONDA_PREFIX/lib
I am sure scikit_build_core define correctly the PREFIX or ORIGIN variable.
stat_tool/src/wrapper/CMakeLists.txt
Outdated
| @@ -0,0 +1,21 @@ | |||
| file(GLOB HEADERS "*.h") | |||
There was a problem hiding this comment.
Here, the aim is to link with the lib vpstat_tool.
And to niclude the headers.
stat_tool/src/wrapper/CMakeLists.txt
Outdated
| file(GLOB HEADERS "*.h") | ||
| file(GLOB SOURCES "*.cpp") | ||
|
|
||
| add_library(_stat_tool MODULE ${SOURCES} ${HEADERS}) |
There was a problem hiding this comment.
This library is a wrapper and need to stay with the Python code...
| add_library(_stat_tool MODULE ${SOURCES} ${HEADERS}) | ||
|
|
||
| target_include_directories(_stat_tool PRIVATE | ||
| ${CMAKE_SOURCE_DIR}/src/cpp |
There was a problem hiding this comment.
The best way is to rely not on the source dir but where the headers have been installed.
This is more robust and will be used in other libs that depend on stat_tool (like sequence_analysis)
Add custom functions
3 participants
Release Structure Analysis