fix(client): fall back when OPENAI_BASE_URL is empty#2988
Open
theamodhshetty wants to merge 1 commit intoopenai:mainfrom
Open
fix(client): fall back when OPENAI_BASE_URL is empty#2988theamodhshetty wants to merge 1 commit intoopenai:mainfrom
theamodhshetty wants to merge 1 commit intoopenai:mainfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENAI_BASE_URLenvironment value the same as an unset onebase_urlarguments unchangedWhy
OPENAI_BASE_URL=""currently bypasses the default API URL fallback becauseos.environ.get(...)returns an empty string rather thanNone. That leaves the client with an invalid base URL even though this path is meant to be the environment defaulting logic.Testing
./.venv/bin/pytest tests/test_client.py -k "base_url_env" -n0./.venv/bin/ruff check src/openai/_client.py tests/test_client.py./.venv/bin/mypy src/openai/_client.py./.venv/bin/pyright -p pyproject.toml src/openai/_client.py