fix(types): add 1080p video sizes (1920x1080, 1080x1920) for sora-2-pro#1790
Open
fuleinist wants to merge 1 commit intoopenai:masterfrom
Open
fix(types): add 1080p video sizes (1920x1080, 1080x1920) for sora-2-pro#1790fuleinist wants to merge 1 commit intoopenai:masterfrom
fuleinist wants to merge 1 commit intoopenai:masterfrom
Conversation
The VideoSize type was missing support for 1080p resolutions that are supported by the sora-2-pro model. According to the OpenAI documentation: 'Use sora-2-pro for higher-resolution exports in 1920x1080 or 1080x1920.' Fixes openai#1789
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for 1080p video resolutions to the VideoSize type.
The sora-2-pro model supports higher-resolution exports in 1920x1080 and 1080x1920, but these sizes were not included in the VideoSize type union.
Changes
'1920x1080'to VideoSize type'1080x1920'to VideoSize typeDocumentation Reference
From the Video generation with Sora guide:
Testing
Fixes #1789