Open
Conversation
Bumps [basic-ftp](https://github.com/patrickjuchli/basic-ftp) from 5.0.5 to 5.2.0. - [Release notes](https://github.com/patrickjuchli/basic-ftp/releases) - [Changelog](https://github.com/patrickjuchli/basic-ftp/blob/master/CHANGELOG.md) - [Commits](patrickjuchli/basic-ftp@v5.0.5...v5.2.0) --- updated-dependencies: - dependency-name: basic-ftp dependency-version: 5.2.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…em-tests/browser-direct-import/basic-ftp-5.2.0 chore(deps): bump basic-ftp from 5.0.5 to 5.2.0 in /ecosystem-tests/browser-direct-import
* chore(internal): refactor imports * refactor(tests): switch from prism to steady * chore(tests): bump steady to v0.19.4 * feat(client): add async iterator and stream() to WebSocket classes * chore(tests): bump steady to v0.19.5 * release: 6.33.0 --------- Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>
) * chore(internal): refactor imports * refactor(tests): switch from prism to steady * chore(tests): bump steady to v0.19.4 * feat(client): add async iterator and stream() to WebSocket classes * chore(tests): bump steady to v0.19.5 * release: 6.33.0 --------- Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>
Release please branches master changes next components OpenAI (…
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a9f7cf398
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+185
to
+188
| return: (): Promise<IteratorReturnResult<undefined>> => { | ||
| done = true; | ||
| cleanup(); | ||
| flushResolvers(); |
There was a problem hiding this comment.
If a caller exits for await (const event of ws.stream()) early and intentionally keeps the socket open—as the docstring says is allowed—return() removes the iterator’s temporary 'error' listener immediately. Any later API/socket error on that still-live connection will then fall back to ResponsesEmitter._onError()'s no-listener path in internal-base.ts, surfacing as an unhandled rejection. In practice this makes the async-iterator API unsafe to use by itself unless callers also remember to bind ws.on('error') or close the socket before breaking.
Useful? React with 👍 / 👎.
#25) Bumps [seroval](https://github.com/lxsmnsyc/seroval) and [solid-js](https://github.com/solidjs/solid). These dependencies needed to be updated together. Updates `seroval` from 0.5.1 to 1.4.2 - [Release notes](https://github.com/lxsmnsyc/seroval/releases) - [Commits](https://github.com/lxsmnsyc/seroval/commits) Updates `solid-js` from 1.7.11 to 1.9.6 - [Release notes](https://github.com/solidjs/solid/releases) - [Changelog](https://github.com/solidjs/solid/blob/main/CHANGELOG.md) - [Commits](solidjs/solid@v1.7.11...v1.9.6) --- updated-dependencies: - dependency-name: seroval dependency-version: 1.4.2 dependency-type: indirect - dependency-name: solid-js dependency-version: 1.9.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Release please branches master changes next components OpenAI (#22) (#23) * chore(internal): refactor imports * refactor(tests): switch from prism to steady * chore(tests): bump steady to v0.19.4 * feat(client): add async iterator and stream() to WebSocket classes * chore(tests): bump steady to v0.19.5 * release: 6.33.0 --------- * chore(deps): bump seroval and solid-js in /ecosystem-tests/vercel-edge (#25) Bumps [seroval](https://github.com/lxsmnsyc/seroval) and [solid-js](https://github.com/solidjs/solid). These dependencies needed to be updated together. Updates `seroval` from 0.5.1 to 1.4.2 - [Release notes](https://github.com/lxsmnsyc/seroval/releases) - [Commits](https://github.com/lxsmnsyc/seroval/commits) Updates `solid-js` from 1.7.11 to 1.9.6 - [Release notes](https://github.com/solidjs/solid/releases) - [Changelog](https://github.com/solidjs/solid/blob/main/CHANGELOG.md) - [Commits](solidjs/solid@v1.7.11...v1.9.6) --- updated-dependencies: - dependency-name: seroval dependency-version: 1.4.2 dependency-type: indirect - dependency-name: solid-js dependency-version: 1.9.6 dependency-type: indirect ... --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Additional context & links