fix: fall back to response body when error field is missing#1775
Open
fuleinist wants to merge 1 commit intoopenai:masterfrom
Open
fix: fall back to response body when error field is missing#1775fuleinist wants to merge 1 commit intoopenai:masterfrom
fuleinist wants to merge 1 commit intoopenai:masterfrom
Conversation
Fixes openai#1734 When an OpenAI-compatible API returns errors in a field other than 'error' (e.g., 'detail'), the Node.js client would show '(no body)'. Now falls back to displaying the entire response body, matching Python client behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an OpenAI-compatible API returns errors in a field other than
error(e.g.,detail), the Node.js client previously showed(no body). This PR adds a fallback to display the entire response body, matching the Python client behavior.Changes
src/core/error.tsto fall back to the full response body when theerrorfield is missingTesting
Fixes #1734