Expose collaboration_mode_kind in turn.started / turn notifications #9845
Conversation
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e69ad4f446
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| items: Vec::new(), | ||
| error: None, | ||
| status: TurnStatus::Completed, | ||
| collaboration_mode_kind: None, |
There was a problem hiding this comment.
In ThreadHistoryBuilder, the new collaboration_mode_kind field is initialized to None but never updated anywhere in this file (repo-wide search in this file shows no assignments beyond this initializer). As a result, turn history reconstructed from stored events will always report collaboration_mode_kind: null even when the recorded turn.started event included a concrete mode. This makes the new client-visible signal disappear after reconnects/history fetches, which undermines the feature outside of the live stream.
Useful? React with 👍 / 👎.
Summary
This threads
collaboration_mode_kindfromTurnContextinto client-visible turn events so TUI/VSCE can render plan/exec modes without relying on plan items.What changed
collaboration_mode_kind: ModeKindtoTurnStartedEvent.TurnContextat core turn entry points.Turn.collaboration_mode_kind: Option<ModeKind>Why
Clients already observe turn lifecycle events. Surfacing the collaboration mode kind there is the simplest, most stable way to let clients special-case rendering for plan mode.