Enterprise session sharing via object storage (/share) #9717
Conversation
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dce27c094
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub chatgpt_base_url: String, | ||
|
|
||
| /// Optional base URL for storing shared session rollouts in an object store. | ||
| pub session_object_storage_url: Option<String>, |
There was a problem hiding this comment.
nit: consider a script path for flexibility
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3465a4c15e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
charley-oai
force-pushed
the
shareable-codex-sessions
branch
from
dddf088 to
7e02688
Compare
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e026882b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11340c8534
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let target_dir = cargo_target_dir()?; | ||
| let filename = format!("{name}{}", env::consts::EXE_SUFFIX); | ||
| let candidate = target_dir.join(filename); | ||
| let abs = absolutize_from_buck_or_cwd(candidate.clone())?; |
There was a problem hiding this comment.
This fallback now assumes the binary already exists at <target_dir>/<name>, but cargo test does not build binaries unless --bins/--all-targets is passed (per cargo test --help, “Test all binaries” is explicitly gated behind --bins). In normal Cargo workflows where CARGO_BIN_EXE_* isn’t set, cargo_bin("codex") will now return ResolvedPathDoesNotExist, causing unwraps like core/tests/suite/cli_stream.rs to fail unless the user has pre-built the bin. The previous assert_cmd::Command::cargo_bin fallback built the binary on demand, so this change introduces a regression for Cargo-based test runs.
Useful? React with 👍 / 👎.
Note: fork the session used to implement this PR with
codex fork 019be7eb-4f0f-7ba3-b0c2-fec2b8790675Just make sure you have the following in your config.toml:
Summary
Adds a tracer‑bullet implementation for enterprise/self‑hosted session sharing. Introduces
session_object_storage_url,a
/shareflow, and object‑store backends (HTTP/Azure) so sessions can be uploaded and referenced by session ID.Demo video: https://drive.google.com/file/d/1NuqRxVea-rHWBB01jVaDnJixSaDIGN1D/view?usp=sharing
What’s Included
/shareslash command (TUI) with basic prompts (scope + emails placeholder)session_object_storage_urlcodex fork <SESSION_ID>will download from object storage when not found locallyMinimal Remaining TODOs (to complete the tracer bullet)
/share)codex resume <SESSION_ID>if desiredAspirational Goals Beyond Demoable MVP