Make auto-review denial short-circuit use a rolling review window#22110
Open
won-openai wants to merge 2 commits intomainfrom
Open
Make auto-review denial short-circuit use a rolling review window#22110won-openai wants to merge 2 commits intomainfrom
won-openai wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Long-running turns can accumulate enough denied auto-review decisions to trip the global short-circuit even when those denials are spread far apart. The breaker should still stop genuinely bad loops, but it should judge recent behavior instead of lifetime turn history.
What changed
10 total denialsthreshold with10 denials in the last 50 reviews.3 consecutive denialsinterrupt behavior unchanged.auto_review_*test names.Validation
just fmtcargo test -p codex-core guardian_rejection_circuit_breaker --libcargo test -p codex-core auto_review_rejection_circuit_breaker --lib