Skip to content

Fix side conversation config inheritance#22106

Open
etraut-openai wants to merge 1 commit intomainfrom
etraut/side-inherit-parent-config
Open

Fix side conversation config inheritance#22106
etraut-openai wants to merge 1 commit intomainfrom
etraut/side-inherit-parent-config

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented May 11, 2026

Addresses #22101

Why

Side conversations are ephemeral forks of the active thread, but /side was building its fork config from the app-level config after refreshing it from disk. If the parent thread had runtime settings that differed from the current persisted defaults, such as a changed model, reasoning effort, permissions, reviewer, or fast-mode selection, the side conversation could start with different behavior than its parent.

What changed

  • Build side fork config from the active parent ChatWidget config, then overlay the parent thread's effective model, reasoning effort, service tier, and fast-mode opt-out state.
  • Forward model reasoning summary, verbosity, personality, web search mode, and service-tier overrides through TUI app-server start/resume/fork lifecycle params.
  • Add focused tests for parent runtime inheritance, side developer guardrail preservation, and lifecycle param forwarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant