Improve goal continuation based on feedback#22045
Open
etraut-openai wants to merge 9 commits intomainfrom
Open
Improve goal continuation based on feedback#22045etraut-openai wants to merge 9 commits intomainfrom
etraut-openai wants to merge 9 commits intomainfrom
Conversation
This reverts commit 64e3ab2.
etraut-openai
changed the title
etraut-openai
changed the title
This was referenced May 11, 2026
|
The change to user message will also resolve: #21291 |
jif-oai
approved these changes
May 11, 2026
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
I like the direction better but the compaction thing must be solved
I approve to unlock
| } | ||
|
|
||
| #[test] | ||
| fn goal_context_does_not_parse_as_visible_turn_item() { |
Collaborator
There was a problem hiding this comment.
I don't think this proves the stale-steer claim. GoalContext is now hidden user context, but collect_user_messages() still drops it during compaction, so an older real steer can remain the last preserved user message after compaction
| FragmentRegistrationProxy::new(); | ||
| static SUBAGENT_NOTIFICATION_REGISTRATION: FragmentRegistrationProxy<SubagentNotification> = | ||
| FragmentRegistrationProxy::new(); | ||
| static GOAL_CONTEXT_REGISTRATION: FragmentRegistrationProxy<GoalContext> = |
Collaborator
There was a problem hiding this comment.
Same, this will still get discarded by compaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the goal continuation prompt to address feedback from early adopters. There are two primary changes:
The user-message transition is important for two reasons. First, it eliminates an issue where older steering messages could be responded to again after a new turn. Second, it works better with compaction because user messages are treated differently from developer messages during compaction.
The prompt refinements make persistence explicit, ground work in current evidence, encourage
update_planfor multi-step progress visibility, and require stronger completion audits before callingupdate_goal. It also removes the elapsed-time reporting in the prompt; I saw evidence that this was causing the model to shortcut work as it became nervous about time.These changes were tested with evals. Chriss4123 has also been running independent evals in #19910, and many of the improvements in this PR were suggested by him.
Verification
codex-corecoverage for hidden goal user context, continuation and budget-limit request shape, prompt rendering, and objective delimiter escaping.