[8/8] Add Python SDK Ruff formatting#22021
Open
aibrahim-oai wants to merge 7 commits intocodex/python-sdk-mock-integration-testsfrom
Open
[8/8] Add Python SDK Ruff formatting#22021aibrahim-oai wants to merge 7 commits intocodex/python-sdk-mock-integration-testsfrom
aibrahim-oai wants to merge 7 commits intocodex/python-sdk-mock-integration-testsfrom
Conversation
Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This was referenced May 10, 2026
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
| testpaths = ["tests"] | ||
|
|
||
| [tool.ruff] | ||
| target-version = "py310" |
There was a problem hiding this comment.
You should be able to omit this, it'll be inferred from the requires-python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Python SDK needs the same tight formatter/lint loop as the rest of the repo: a safe Ruff autofix pass, Ruff formatting, editor save behavior, and CI checks that catch drift. Without that loop, SDK changes can land with formatting or import ordering that differs from what reviewers and CI expect.
What
sdk/python/pyproject.toml, excluding generated protocol code and notebooks from the normal lint/format pass.just fmtso it still formats Rust and also runs Python SDK Ruff autofix and formatting.ruff checkandruff format --checkbefore pytest.v2_all.pyoutput emitted by the pinned generator.just fmtrecipe so it keeps working from both Rust and Python SDK working directories.Stack
[1/8]Pin Python SDK runtime dependency[2/8]Generate Python SDK types from pinned runtime[3/8]Run Python SDK tests in CI[4/8]Define Python SDK public API surface[5/8]Rename Python SDK package toopenai-codex[6/8]Add high-level Python SDK approval mode[7/8]Add Python SDK app-server integration harness[8/8]Add Python SDK Ruff formattingVerification
test_root_fmt_recipe_formats_rust_and_python_sdkfor the shared format recipe.just fmtafter the recipe update.