Add hook visibility hints#21972
Open
abhinav-oai wants to merge 5 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 012d0aa0ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced May 10, 2026
abhinav-oai
commented
May 10, 2026
Collaborator
Author
|
what if we take this a step further and offer a better OOTB experience since the current
|
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hook lifecycle rendering can be pretty noisy because it has to do two jobs at once: tell users about consequential hook behavior, and surface background work that only exists to provide model context.
This issue cluster asks for a way to separate those concerns:
This replaces the managed-hook-only suppression approach from #21577 with a presentation hint that preserves the full lifecycle stream while letting clients decide what should stay in the foreground.
What
visibilityHint = "default" | "quiet" | "verbose"config and carry it throughHookRunSummaryplus app-server lifecycle notificationsdefaultthe concise everyday rendering mode, keepquietfor hooks that should avoid transient rows, and reserveverbosefor the full hook streamvisibilityHintis a rendering hint, not a suppression primitiveTUI rendering rules
visibilityHintWarning,Feedback,Stop,Error)defaultContextentriesquietContextentriesverboseBlocked, failed, and stopped hooks always render a row;
defaultandquietstill elideContextentries from those rows.