[exec-server] serve websockets via HTTP upgrade#21963
Draft
euroelessar wants to merge 1 commit intomainfrom
Draft
[exec-server] serve websockets via HTTP upgrade#21963euroelessar wants to merge 1 commit intomainfrom
euroelessar wants to merge 1 commit intomainfrom
Conversation
8d10c0c to
7cc55f4
Compare
7cc55f4 to
6f40914
Compare
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex exec-servercurrently exposes a raw websocket listener. Serving the websocket over an HTTP upgrade route makes it compatible with intermediate HTTP proxies and lets the same listener expose ordinary HTTP health endpoints.What changed
ws://<addr>/wsusing an HTTP upgrade routeGET /,GET /readyz, andGET /healthzfrom the same listener/wsendpointVerification
cargo test -p codex-exec-server --test health --test process --test websocket --test initialize --test exec_processcargo test -p codex-app-server-protocol environment_addcargo test -p codex-core environment_selectioncargo test -p codex-app-server-client runtime_start_args_forward_environment_managercargo test -p codex-app-server turn_start_resolves_sticky_thread_local_environment_and_turn_overridescargo test -p codex-tui config_cwd_for_app_server_target_omits_cwd_for_remote_exec_servercargo test -p codex-exec-serverreaches unrelatedfile_systemsandbox-helper failures in this environment after the websocket tests pass