Fix goal update and add /goal edit command in TUI#21954
Open
etraut-openai wants to merge 5 commits intomainfrom
Open
Fix goal update and add /goal edit command in TUI#21954etraut-openai wants to merge 5 commits intomainfrom
/goal edit command in TUI#21954etraut-openai wants to merge 5 commits intomainfrom
Conversation
/goal edit command in TUI
/goal edit command in TUI/goal edit command in TUI
charliemarsh-oai
approved these changes
May 9, 2026
Contributor
|
When testing |
Collaborator
Author
|
@canvrno-oai, good catch! I forgot that my original implementation cleared the goal time/token accounting when the objective was updated. That design decision no longer makes sense for the |
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Users have requested the ability to edit a goal's objective after a goal has been created. This PR exposes a new
/goal editcommand in the TUI to address this request.In the process of implementing this, I also noticed an existing bug in the goal runtime. When a goal's objective is updated through the
thread/goal/setapp server API, the goal runtime didn't emit a new steering prompt to tell the agent about the new objective. This PR also fixes this hole.What Changed
/goal editin the TUI, opening an edit box prefilled with the current goal objective.thread/goal/setbehavior so editing an objective preserves goal accounting instead of resetting it. The older reset-on-new-objective behavior was left over from beforethread/goal/clear; clients that need to reset accounting can now clear the existing goal and create a new one.Validation
/goal editreturns an error if no goal currently exists/goal editdisplays an edit box that can be optionally canceled with no side effects/goalto display the goal summary/goal editdoesn't reset the token budget, time/token accounting on the updated goal